Disconnect between StudentDisciplineIncidentAssociation and DisciplineAction

Summary of outcomes for Data Standard 3.0

• Problem Addressed: Prior to v3.0, the DisciplineAction entity contained separate references to Student and DisciplineIncident, making it possible for a student to be assigned a DisciplineAction for a DisciplineIncident with which the student was not associated.
• High-level Reasoning: A student may be assigned a discipline action that is meant to cover multiple discipline incidents. Since a discipline action should be specific to a student, the student reference must be part of the key (and not a collection) - requiring separate references due to cardinality differences. However, by keeping the Student reference on DisciplineAction as part of the key and replacing the collection of DisciplineIncident references with a collection of StudentDisciplineIncidentAssociations, the same semantics may be achieved while still ensuring that discipline action is not assigned to students who weren't associated with an incident. By merging the Student reference with StudentDisciplineIncidentAssociation.Student, only incidents associated with the student to whom the action is assigned may be referenced.
• Changes Made: The DisciplineIncident reference on DisciplineAction was replaced with an optional collection of StudentDisciplineIncidentAssociations. StudentDisciplineIncident.Student was merged with Student.

Original ticket description follows:

Within the API it is possible to submit DisciplineAction for a student without submitting StudentDisciplineIncidentAssociation or vice versa.  It is problemmatic as the offending behavior is disconnected from the actual discipline action.  This impacts our state reporting as we have seen multiple instances of one endpoint being submitted without the other.  Without a direct connection the true relationship may also be cloudy when multiple students are involved. 

We suggest that DisciplineAction reference StudentDisciplineIncidentAssociation rather than just DisciplineIncident to more closely relate the behavior to the discipline action.